Empty error handler()

Author[]

Janek Kozicki

Synopsis[]

See related patch Xinerama and X ConfigureWindow fix, and ML short discussion: [1].

After some testing I can say that error_handler() isn't necessary at all. I don't know Xlib good enough to know how to remove it, so, I just propose to make it empty.

Patch testing[]

Copy/paste the patch listed below into some file, eg. TEST.diff.
If you don't have sawfish sources yet, have one, as described get it from GIT repo.
Go into the directory where sawfish sources reside, eg. cd sawfish
Test if the patch applies cleanly with this command:
```
patch -p1 --ignore-whitespace --dry-run < TEST.diff
```
in case of problems try also: -p0 or -p2
If it applies cleanly, then remove the --dry-run from above command and run it again, otherwise ask on the mailing list.
Compile sawfish: ./autogen.sh && make
Install it for testing, but it depends on your linux distribution.
1. It is always better to install sawfish as your distribution package, but it is different for each distribution.
2. So you may try make install, which will install sawifish in /usr/local/share/sawfish/ (if you have write access). But then make sure that you run the correct version and delete it from that directory afterwards, to avoid any conflicts.
Se also
- how to prepare a patch - this instruction is useful for patch testing also.
- Patch testing howto for practical tips.

PS: edit this template if you feel that those instructions can be improved.

Patch[]

replace error_handler() in display.c with following:

static int
error_handler (Display *dpy, XErrorEvent *ev)
{
    return 0;
}

Community's reasons for inclusion or rejection[]

Patch submitters, please vote also! Yes, obviously your vote will be positive, but it's the place to give your explanation why this patch is good for all Sawfish users, and why it is correct - good reasons for inclusion.

When voting anonymously please write your name, so that it can be associated with your posts on the mailing list. If you are logged in you can sign yourself by typing four tilda characters: ~~~~.

Please vote with: vote: yes., vote: no., vote: let's try in experimental., vote: pondering. or wait for next release.

vote: yes. Unless someone can reason why it should stay I propose to remove it.
vote: pondering. We'll soon release 1.6, so if we apply it soon after the release, we'll have enough testing period. I've been using it for 10 days, but haven't got any problem.
The error handler is registered in the same file, and you can easily find it. (Search for XSetErrorHandler) But it is used twice, and the first one seems to be used to detect other window manager if one is run. So complete deletion beyond this patch needs sure reasoning. - Teika kazura 08:32, December 15, 2009 (UTC)

Yes, we can do that after the release. This makes more sense. Janek Kozicki 08:52, December 15, 2009 (UTC)