Fix sawfish server connection

Author

Alexey I. Froloff (ALT Linux)

Synopsis

Without this patch sawfish does not accept connections from sawfish-ui and sawfish-client with error:

$ sawfish-ui 
eval_req: Broken pipe
*** Remote sawfish error: unknown error

Broken by SVN revision 4275.

Patch testing

1. Copy/paste the patch listed below into some file, eg. TEST.diff.
2. If you don't have sawfish sources yet, have one, as described get it from GIT repo.
3. Go into the directory where sawfish sources reside, eg. cd sawfish
4. Test if the patch applies cleanly with this command:

   patch -p1 --ignore-whitespace --dry-run < TEST.diff

   in case of problems try also: -p0 or -p2
5. If it applies cleanly, then remove the --dry-run from above command and run it again, otherwise ask on the mailing list.
6. Compile sawfish: ./autogen.sh && make
7. Install it for testing, but it depends on your linux distribution.
   1. It is always better to install sawfish as your distribution package, but it is different for each distribution.
   2. So you may try make install, which will install sawifish in /usr/local/share/sawfish/ (if you have write access). But then make sure that you run the correct version and delete it from that directory afterwards, to avoid any conflicts.
8. Se also
   • how to prepare a patch - this instruction is useful for patch testing also.
   • Patch testing howto for practical tips.

PS: edit this template if you feel that those instructions can be improved.

Patch

commit e024572124cdae8899cac3e2dc0d33292aad6d45
Author: Alexey I. Froloff <raorn@altlinux.org>
Date:   Sat Dec 27 18:53:14 2008 +0300

    addr_len should be initialized.
    
    Signed-off-by: Alexey I. Froloff <raorn@altlinux.org>

diff --git a/src/server.c b/src/server.c
index 05646c7..95e8dd0 100644
--- a/src/server.c
+++ b/src/server.c
@@ -143,7 +143,7 @@ server_accept_connection(int unused_fd)
 {
     int confd;
     struct sockaddr_un addr;
-    socklen_t addr_len;
+    socklen_t addr_len = sizeof(addr);
 
     /* Linux manpage states that we can pass NULL for addr parameters,
        but that has been reported to crash on some systems.. */

Community's reasons for inclusion or rejection

Patch submitters, please vote also! Yes, obviously your vote will be positive, but it's the place to give your explanation why this patch is good for all Sawfish users, and why it is correct - good reasons for inclusion.

When voting anonymously please write your name, so that it can be associated with your posts on the mailing list. If you are logged in you can sign yourself by typing four tilda characters: ~~~~.

• Please vote with: vote: yes., vote: no., vote: let's try in experimental., vote: pondering. or wait for next release.
• vote: yes. Raorn 16:04, 27 December 2008 (UTC)

• vote: yes. Thanks, commited. rev4338 Flashrider [Christopher Bratusek] 19:18, 28 December 2008 (UTC)